Skip to content

Added Dutch language - #4012

Merged
Kartik Raj (karrtikr) merged 5 commits into
microsoft:masterfrom
Bowero:master
Feb 11, 2019
Merged

Added Dutch language#4012
Kartik Raj (karrtikr) merged 5 commits into
microsoft:masterfrom
Bowero:master

Conversation

@Bowero

Copy link
Copy Markdown

I have tried to make a first translation to Dutch. Most Dutch developers tend to use the English version of applications because we are used to the English references. This is the reason you will see a lot of English words in the translation.

I'd like to hear what you would change.

(thanks Robin Martijn) 🥇

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jan 16, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@codecov

codecov Bot commented Jan 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4012 into master will increase coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4012    +/-   ##
=======================================
+ Coverage      79%     79%    +1%     
=======================================
  Files         408     410     +2     
  Lines       19006   18971    -35     
  Branches     3040    3073    +33     
=======================================
+ Hits        14825   14889    +64     
+ Misses       4179    4079   -100     
- Partials        2       3     +1
Flag Coverage Δ
#Linux 68% <ø> (+1%) ⬆️
#Windows 69% <ø> (+1%) ⬆️
#macOS 68% <ø> (ø) ⬇️

@d3r3kk

Copy link
Copy Markdown

Robin Martijn (@Bowero) thanks for the submission, we really appreciate it.

Please note that we generally look at externally contributed PRs in the next following sprint, so we might not get to this until early February.

Comment thread package.nls.nl.json Outdated
"diagnostics.disableSourceMaps": "Bronkaartondersteuning uitschakelen",
"diagnostics.warnBeforeEnablingSourceMaps": "Bronkaartondersteuning inschakelen in de Python-extensie zal een ongunstige impact hebben op de uitvoering van de extensie.",
"diagnostics.enableSourceMapsAndReloadVSC": "Venster inschakelen en herladen",
"diagnostics.lsNotSupported": "Uw besturingssysteem voldoet niet aan de minimumeisen van de taalserver. Aan het terugschakelen naar het alternatief, Jedi.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the term language server is better here since that is something people can google on. Or perhaps something like Uw besturingssysteem voldoet niet aan de minimumeisen van de taalserver (language server).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I personally prefer your first solution.

Comment thread package.nls.nl.json Outdated
"debug.debugPyramidConfigurationLabel": "Pyramid",
"debug.debugPyramidConfigurationDescription": "Web-applicatie",
"debug.djangoEnterManagePyPathTitle": "Django debuggen",
"debug.djangoEnterManagePyPathPrompt": "Voer een pad in naar manage.py ('${workspaceFolderToken}' punten naar de root van de huidige werkruimtemap)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

punten -> verwijzen

Voer een pad in naar manage.py ('${workspaceFolderToken}' verwijzen naar de root van de huidige werkruimtemap)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! That explains so much! I couldn't figure out the purpose of that sentence and was waiting for someone to point that one out.

@DonJayamanne

Copy link
Copy Markdown

Michael van Tellingen (@mvantellingen) Robin Martijn (@Bowero) are you happy with the latest changes.

@DonJayamanne

Copy link
Copy Markdown

Fixes #4186

@DonJayamanne

Copy link
Copy Markdown

Robin Martijn (@Bowero) Please could you create a news entry file for #4186
Instructions are here:https://github.com/Microsoft/vscode-python/tree/master/news

Or:

  • create a file named news\1 Enhancements\4186.md
  • Add the following content into the above file:
Added Dutch translation.
   (thanks [Robin Martijn](https://github.com/Bowero))

This file will ensure you get credit for your work in our change log.

@DonJayamanne

Copy link
Copy Markdown

FYI - we plan on releasing a new version tomorrow. If Michael van Tellingen (@mvantellingen) Robin Martijn (@Bowero) are happy with the current translation then we can include this into the release.

@Bowero

Copy link
Copy Markdown
Author

I am happy with the PR as it is now and would like to see it included in the next release. Thanks for the help guys!

@DonJayamanne

Copy link
Copy Markdown

Robin Martijn (@Bowero) as Michael van Tellingen (@mvantellingen) hasn't confirmed he's happy with the changes, I've deferred this for the next release.
If someone else validates the changes, we'll merge it, its just that no one in our team is able to validate the PR, hence the reason to rely on OSS community to review and provide their feedback.

Once again, once someone else has ok'ed the PR, we'll merge it and it will get released.
Thanks again

Comment thread package.nls.nl.json Outdated
"debug.moduleEnterModulePrompt": "Voer Python module/package naam in",
"debug.moduleEnterModuleInvalidNameError": "Voer een geldige naam in",
"debug.pyramidEnterDevelopmentIniPathTitle": "Pyramid debuggen",
"debug.pyramidEnterDevelopmentIniPathPrompt": "`Voer een pad in naar development.ini ('${workspaceFolderToken}' punten naar de root van de huidige werkruimtemap)`",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be updated: punten -> verwijzen

Comment thread package.nls.nl.json Outdated
"python.snippet.launch.attach.description": "De debugger voor debugging op afstand aankoppelen",
"python.snippet.launch.scrapy.label": "Python: Scrapy",
"python.snippet.launch.scrapy.description": "Scrapy met geintegreerde terminal/console",
"LanguageService.bannerMessage": "Zou je alsjeblieft 2 minuten kunnen nemen om ons te vertellen hoe de Python-taalserver voor jou werkt?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taalserver -> Language server to be consistent with the earlier change. It think it's good to also do this for the other strings

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Comment thread package.nls.nl.json Outdated
"DataScience.export": "Als Jupyter-Notebook exporteren",
"DataScience.restartServer": "iPython-kernel herstarten",
"DataScience.undo": "Ongedaan maken",
"DataScience.redo": "Overdoen",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most programs translate this to Herhaal or Opnieuw uitvoeren i believe

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@mvantellingen

Copy link
Copy Markdown

Sorry for not responding earlier. I've added some minor feedback. Although i'm not using the dutch translations its pretty awesome to have them :-) Thanks for the work Robin Martijn (@Bowero)

@Bowero

Copy link
Copy Markdown
Author

I see that I have missed some things when I worked on your previous suggestions. It is great to have an extra pair of eyes. Thank you so much for helping!

@karrtikr
Kartik Raj (karrtikr) merged commit 5bfd2ad into microsoft:master Feb 11, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants