Skip to content

gh-978: Escape the pipenv executable for activation.#3975

Merged
ericsnowcurrently merged 1 commit into
microsoft:masterfrom
ericsnowcurrently:fix-978-add-pipenvPath-setting
Jan 14, 2019
Merged

gh-978: Escape the pipenv executable for activation.#3975
ericsnowcurrently merged 1 commit into
microsoft:masterfrom
ericsnowcurrently:fix-978-add-pipenvPath-setting

Conversation

@ericsnowcurrently
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently commented Jan 14, 2019

(for #978)

I missed a corner case in #3957. This fixes it.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Jan 14, 2019
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jan 14, 2019
Merged
4 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2019 •
edited
Loading

Codecov Report

Merging #3975 into master will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3975   +/-   ##
======================================
+ Coverage      78%     78%   +1%     
======================================
  Files         406     406           
  Lines       18892   18892           
  Branches     3028    3028           
======================================
+ Hits        14642   14644    +2     
+ Misses       4248    4246    -2     
  Partials        2       2
Flag Coverage Δ
#Linux 68% <0%> (+1%) ⬆️
#Windows 68% <0%> (+1%) ⬆️
#macOS 68% <0%> (ø) ⬇️
Impacted Files Coverage Δ
...entActivationProviders/pipEnvActivationProvider.ts 79% <100%> (ø) ⬆️
src/client/interpreter/helpers.ts 79% <0%> (-1%) ⬇️
src/client/common/platform/fileSystem.ts 64% <0%> (ø) ⬇️
src/client/providers/jediProxy.ts 77% <0%> (ø) ⬇️
src/client/common/process/pythonProcess.ts 93% <0%> (+2%) ⬆️
...rpreter/locators/services/baseVirtualEnvService.ts 88% <0%> (+3%) ⬆️
...tors/services/workspaceVirtualEnvWatcherService.ts 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c013089...efe8172. Read the comment docs.

@ericsnowcurrently
Copy link
Copy Markdown
Author

ericsnowcurrently commented Jan 14, 2019

close-reopen to re-trigger CI

@ericsnowcurrently ericsnowcurrently merged commit 7706633 into microsoft:master Jan 14, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-978-add-pipenvPath-setting branch January 14, 2019 20:22
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @DonJayamanne