Skip to content

Ensure extension does not start multiple instances of LS at a time#3974

Merged
DonJayamanne merged 17 commits into
microsoft:masterfrom
DonJayamanne:issue3346
Jan 15, 2019
Merged

Ensure extension does not start multiple instances of LS at a time#3974
DonJayamanne merged 17 commits into
microsoft:masterfrom
DonJayamanne:issue3346

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jan 14, 2019

For #3346

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2019

Codecov Report

Merging #3974 into master will decrease coverage by 53%.
The diff coverage is 30%.

@@            Coverage Diff            @@
##           master   #3974      +/-   ##
=========================================
- Coverage      78%     25%     -52%     
=========================================
  Files         406     331      -75     
  Lines       18892   13888    -5004     
  Branches     3028    2146     -882     
=========================================
- Hits        14642    3465   -11177     
- Misses       4248   10395    +6147     
- Partials        2      28      +26
Flag Coverage Δ
#Linux ?
#Windows ?
#macOS ?

@DonJayamanne DonJayamanne changed the title WIP - Ensure extension does not start multiple instances of LS at a time Ensure extension does not start multiple instances of LS at a time Jan 14, 2019
Comment thread src/test/activation/languageServer/manager.unit.test.ts Outdated
Comment thread package.json Outdated
Comment thread src/client/common/logger.ts Outdated
Comment thread src/test/telemetry/index.unit.test.ts Outdated
Comment thread src/client/activation/languageServer/languageClientFactory.ts Outdated
Comment thread src/client/activation/languageServer/manager.ts
Comment thread src/client/activation/languageServer/manager.ts Outdated
Comment thread src/client/activation/languageServer/manager.ts Outdated
Comment thread src/client/activation/languageServer/manager.ts Outdated
@DonJayamanne DonJayamanne deleted the issue3346 branch May 24, 2019 20:22
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants