Skip to content

Refactor debug configuration providers#3742

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:refactorDebugConfig
Dec 18, 2018
Merged

Refactor debug configuration providers#3742
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:refactorDebugConfig

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #3321

  • Created a separate PR to refactor before introducing changes related to 3321
  • Easier to review and merge (smaller changes)
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Comment thread src/client/debugger/extension/configuration/resolvers/base.ts
@DonJayamanne DonJayamanne merged commit 4f237b4 into microsoft:master Dec 18, 2018
@DonJayamanne DonJayamanne deleted the refactorDebugConfig branch May 24, 2019 20:23
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants