Updated logic used to determine whether the Language Server is supported#3565
Merged
Conversation
d3r3kk
approved these changes
Dec 8, 2018
d3r3kk
left a comment
There was a problem hiding this comment.
Nice change. Good simplification.
Two changes you pose here are probably better served by moving into their own independant PRs (trace statements, and updates to CI) but I'll let you decide to do that or not. I'm for splitting them out, but it's not the end of my world if you don't.
I left a question in one comment: How can a user on a Linux distro that isn't specifically supported still use the LS?
2793e41 to
b159a61
Compare
Author
They can't. |
This reverts commit 0b25d16.
b825dc3 to
db75120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2729
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)