Activate the conda environment before running jupyter#3506
Merged
Conversation
Add unit tests for it
rchiodo
commented
Nov 29, 2018
rchiodo
commented
Nov 29, 2018
Author
|
@IanMatthewHuff did you want anymore changes? |
Author
|
@DonJayamanne or @brettcannon do you guys want to take a look? |
|
Will check |
DonJayamanne
requested changes
Nov 29, 2018
DonJayamanne
left a comment
There was a problem hiding this comment.
This looks good, still need to review.
DonJayamanne
requested changes
Nov 30, 2018
DonJayamanne
approved these changes
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the conda activate script and scrape all of the environment from it prior to launching jupyter (or any other command with the same interpreter)
I'm hoping this will finally fix #3341.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)