Skip to content

Expose API to get command for launching debugger in remote debug mode#3399

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue3121API
Nov 20, 2018
Merged

Expose API to get command for launching debugger in remote debug mode#3399
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue3121API

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #3121

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [no] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@d3r3kk d3r3kk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions for your consideration.

Comment thread src/client/api.ts Outdated
Comment thread src/client/debugger/debugAdapter/DebugClients/LocalDebugClient.ts Outdated
Comment thread src/client/debugger/debugAdapter/DebugClients/launcherProvider.ts
Comment thread src/client/extension.ts Outdated
@DonJayamanne DonJayamanne merged commit 0ab1384 into microsoft:master Nov 20, 2018
@DonJayamanne DonJayamanne deleted the issue3121API branch December 14, 2018 22:08
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants