Progress indicator when loading interpreters and speed up detection of new virtual envs in workspace#3079
Merged
Conversation
* issue3000CDN: Use separate urls for querying and downloading
* issue3000CDN: Fix tests Fix tests
d3r3kk
suggested changes
Nov 1, 2018
d3r3kk
left a comment
There was a problem hiding this comment.
I think separating the AzureCDN and interpreter fs watcher changes into separate PRs should be considered.
332fead to
299909c
Compare
Author
|
New changes:
@d3r3kk Please re-review (until I get the tests fixed) |
…/pythonVSCode into issue656Interpreter
…/pythonVSCode into issue656Interpreter * 'issue656Interpreter' of https://github.com/DonJayamanne/pythonVSCode: Fire notification immediately Fix tests Fix tests Use separate urls for querying and downloading Speed up interpreter detection
brettcannon
approved these changes
Nov 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #656
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)