Skip to content

Correct test failures related to the Black formatter.#3002

Merged
d3r3kk merged 2 commits into
microsoft:masterfrom
d3r3kk:2999_fix-formatter
Oct 24, 2018
Merged

Correct test failures related to the Black formatter.#3002
d3r3kk merged 2 commits into
microsoft:masterfrom
d3r3kk:2999_fix-formatter

Conversation

@d3r3kk
Copy link
Copy Markdown

@d3r3kk d3r3kk commented Oct 24, 2018

Fixes #2999

  • Check for all unsupported versions of Python during formatter tests

  • Skip unsupported versions

  • Rename test suite to make it more grep-able

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)

  • Title summarizes what is changing

  • Has a news entry file (remember to thank yourself!)

  • Unit tests & system/integration tests are added/updated

  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Fixes microsoft#2999

- Check for all unsupported versions of Python during formatter tests
- Skip unsupported versions
- Rename test suite to make it more grep-able
@d3r3kk d3r3kk merged commit 62cad88 into microsoft:master Oct 24, 2018
@d3r3kk d3r3kk deleted the 2999_fix-formatter branch October 24, 2018 21:23
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct long-standing test problem Formatting "before all" hook to do with black not being installed (py3.4, 3.5)

2 participants