Disable consistently failing tests for specific OS and Python versions to get CI running clean.#2944
Merged
Merged
Conversation
DonJayamanne
requested changes
Oct 18, 2018
- Move common functionality out of the serviceRegistry for tests: - 'get python version' functionality - Added common functionality: - shouldSkipForOses - shouldSkipForPythonVersions - Each disabled test is tracked by an open issue - Each disabled test has a comment indicating why
- Logic for determining equality between version specs and python version updated - More relevant naming of test util functions - use of SemVer for version comparison - better than strings!
6219d07 to
8e5e6ed
Compare
DonJayamanne
approved these changes
Oct 19, 2018
Author
|
Rebuild... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2795
Specific known tests are disabled for specific OS and Python version test runs only. Once the rolling-CI build runs 'green' on Azure DevOps, we can turn on warnings as errors so that the build results become meaningful.
Each disabled test is commented to indicate the issue that tracks it's re-enabling
Common test utility code moved to
src/test/common.tsPull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Unit tests & system/integration tests are added/updated
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)