Skip to content

Add support for multi proc debugging#2912

Merged
DonJayamanne merged 5 commits into
microsoft:masterfrom
DonJayamanne:multiProcFinal
Oct 18, 2018
Merged

Add support for multi proc debugging#2912
DonJayamanne merged 5 commits into
microsoft:masterfrom
DonJayamanne:multiProcFinal

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #80

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the name change of @log decorator.

Comment thread src/client/extension.ts Outdated

const handlers = serviceManager.getAll<ICustomDebugSessionEventHandlers>(ICustomDebugSessionEventHandlers);
const disposables = serviceManager.get<IDisposableRegistry>(IDisposableRegistry);
const dispather = new CustomDebugSessionEventDispatcher(handlers, DebugService.instance, disposables);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: dispatcher

@DonJayamanne DonJayamanne merged commit a77a10e into microsoft:master Oct 18, 2018
@DonJayamanne DonJayamanne deleted the multiProcFinal branch October 31, 2018 17:37
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants