Improvements to algorithm used to identify virtual environments#2788
Merged
DonJayamanne merged 1 commit intoOct 4, 2018
Merged
Conversation
d3r3kk
approved these changes
Oct 3, 2018
d3r3kk
left a comment
There was a problem hiding this comment.
Some nits that you can feel free to ignore (spelling, wording).
| if (workspacesUris.findIndex(uri => event.affectsConfiguration('python.pythonPath', uri)) === -1) { | ||
| return; | ||
| } | ||
| // Lets wait, for more changes, dirty simple throttling. |
| } | ||
| this.timeOut = setTimeout(() => { | ||
| this.timeOut = undefined; | ||
| this.diagnose().then(dianostics => this.handle(dianostics)).ignoreErrors(); |
|
|
||
| const pyEnvRoot = await this.getPyEnvRoot(resource); | ||
| if (pyEnvRoot && pythonPath.startsWith(pyEnvRoot)) { | ||
| if (await this.isPyEnvEnvironment(pythonPath, resource)) { |
There was a problem hiding this comment.
This looks like a great candidate to spark discussion of different approaches to the design. Your change here works with the current design, but also complements a future adjustment to using (perhaps) a visitor pattern type solution to determine env type. Notes for later!
Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #
package.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)