Skip to content

Move utils into common folder#2749

Merged
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:moveUtils
Oct 9, 2018
Merged

Move utils into common folder#2749
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:moveUtils

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #2748

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the situation with text.ts, LGTM.

@@ -0,0 +1,113 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to move this file rather than just copy it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move.

@DonJayamanne DonJayamanne merged commit 90aedaa into microsoft:master Oct 9, 2018
@DonJayamanne DonJayamanne deleted the moveUtils branch October 9, 2018 22:47
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants