Skip to content

Fix debugger adapter capabilities test#2659

Merged
DonJayamanne merged 5 commits into
microsoft:masterfrom
DonJayamanne:fixDebuggerTests
Sep 25, 2018
Merged

Fix debugger adapter capabilities test#2659
DonJayamanne merged 5 commits into
microsoft:masterfrom
DonJayamanne:fixDebuggerTests

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #2658

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has unit tests & system/integration tests
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change request and one question.

Comment thread src/test/debugger/capabilities.test.ts Outdated
Comment thread src/test/debugger/capabilities.test.ts Outdated
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one change request for you.

@DonJayamanne
Copy link
Copy Markdown
Author

Add issue #2672 for this skipped test.

@DonJayamanne
Copy link
Copy Markdown
Author

@d3r3kk
Please review

@DonJayamanne
Copy link
Copy Markdown
Author

@d3r3kk
Please re-review.

Comment thread src/test/debugger/capabilities.test.ts
Comment thread src/test/index.ts
@DonJayamanne DonJayamanne merged commit be2ae45 into microsoft:master Sep 25, 2018
@DonJayamanne DonJayamanne deleted the fixDebuggerTests branch October 2, 2018 22:45
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants