Skip to content

Use a python script to launch the debugger#2554

Merged
DonJayamanne merged 9 commits into
microsoft:masterfrom
DonJayamanne:issue2509PTVSDPath
Sep 13, 2018
Merged

Use a python script to launch the debugger#2554
DonJayamanne merged 9 commits into
microsoft:masterfrom
DonJayamanne:issue2509PTVSDPath

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #2509

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has unit tests & system/integration tests
  • [n/a] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne requested a review from d3r3kk September 12, 2018 15:58
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, I suspect so long as the debugger tests pass this should be ok.

Comment thread src/client/debugger/DebugClients/LocalDebugClient.ts Outdated
@DonJayamanne DonJayamanne merged commit a464d9c into microsoft:master Sep 13, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python Debugger is overiding PYTHONPATH

2 participants