Skip to content

Remove typeshed submodule and rely on LS package typeshed#2404

Merged
MikhailArkhipov merged 62 commits into
microsoft:masterfrom
MikhailArkhipov:master
Aug 21, 2018
Merged

Remove typeshed submodule and rely on LS package typeshed#2404
MikhailArkhipov merged 62 commits into
microsoft:masterfrom
MikhailArkhipov:master

Conversation

@MikhailArkhipov
Copy link
Copy Markdown

@MikhailArkhipov MikhailArkhipov commented Aug 16, 2018 •
edited
Loading

Fixes #2182
Fixes #2405
Add news for LS outline fix.

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

MikhailArkhipov and others added 30 commits June 8, 2018 14:07
LS symbol providers
997635a
Merge branch 'master' of https://github.com/Microsoft/vscode-python
f6c6276
Merge branch 'master' of https://github.com/Microsoft/vscode-python
0a20fef
Merge branch 'master' of https://github.com/Microsoft/vscode-python
660a627
Merge branch 'master' of https://github.com/Microsoft/vscode-python
3813395
Different ready wait
d4fd3ab
Merge branch 'master' of https://github.com/Microsoft/vscode-python
3a0bea4
Upgrade dependencies to latest LS
56bf688
Make open files only default
37f1154
Turn off hash checks
4092bcc
Fix double progress display
49ec38a
Update packages
f7e245b
@brettcannon
Anchor dependencies
bdce0ff
Merge branch 'master' of https://github.com/Microsoft/vscode-python
969db02
Merge master
13828ca
Add setting for diag throttling
5d45558
Add MacOS version check
70b13f7
News
462ff7c
Correct MacOS check and lay infra for Linux checks
4e12b3c
Linux version check
0d3c066
Linux check
925f663
Simplify
fef0e92
Test prep
2c7243c
Platform tests
07dc2fa
Mac compat tests
cd970be
Ubuntu tests
c63c904
Revert "Ubuntu tests"
42ebdd1 
This reverts commit c63c904.
Revert "Mac compat tests"
d3c7acb 
This reverts commit cd970be.
Revert "Platform tests"
d86997b 
This reverts commit 07dc2fa.
Revert "Test prep"
5caca65 
This reverts commit 2c7243c.
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 16, 2018 •
edited
Loading

Codecov Report

Merging #2404 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
- Coverage   75.38%   75.38%   -0.01%     
==========================================
  Files         309      309              
  Lines       14331    14330       -1     
  Branches     2537     2536       -1     
==========================================
- Hits        10804    10803       -1     
  Misses       3518     3518              
  Partials        9        9
Flag Coverage Δ
#MacOS 74.17% <0%> (-0.03%) ⬇️
#Windows 74.29% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/activation/languageServer.ts 25.68% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6707eaa...e24c7e5. Read the comment docs.

brettcannon
brettcannon reviewed Aug 16, 2018
View reviewed changes
Comment thread package.json
"python.analysis.logLevel": {
"type": "string",
"enum": [
"Error",
Copy link
Copy Markdown
Member

@brettcannon brettcannon Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the enum values be lowercase to match the default?

Copy link
Copy Markdown
Author

@MikhailArkhipov MikhailArkhipov Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should match what we use in other settings. Fixed default.

Comment thread package.json Outdated
"python.analysis.traceLogging": {
"type": "boolean",
"default": false,
"description": "Enables full diagnostic logging in the language server.",
Copy link
Copy Markdown
Member

@brettcannon brettcannon Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from e.g. information logging?

Copy link
Copy Markdown
Author

@MikhailArkhipov MikhailArkhipov Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is even deeper setting, produces tons of stuff. I'll check if it is easy enough to unify with other levels, but currently it is a separate flag in LS code base, might affect VS as well.

@MikhailArkhipov
Copy link
Copy Markdown
Author

MikhailArkhipov commented Aug 17, 2018

microsoft/PTVS#4656 LS part

@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Aug 20, 2018

@MikhailArkhipov FYI it looks like the CI failures are due to needing to commit the updates to package-lock.json.

@MikhailArkhipov
Copy link
Copy Markdown
Author

MikhailArkhipov commented Aug 20, 2018 •
edited
Loading

No, it is an issue with some unrelated mocks.

[14:15:59] Using gulpfile F:\VSCP\gulpfile.js
[14:15:59] Starting 'checkNativeDependencies'...
[14:16:06] Finished 'checkNativeDependencies' after 6.36 s
src/test/mocks/vsc/extHostedTypes.ts:506:18 - error TS2720: Class 'import("F:/VSCP/src/test/mocks/vsc/extHostedTypes").vscMockExtHostedTypes.WorkspaceEdit' incorrectly implements class ''vscode'.WorkspaceEdit'. Did you mean to extend ''vscode'.WorkspaceEdit' and inherit its members as a subclass?
  Property 'createFile' is missing in type 'WorkspaceEdit'.

506     export class WorkspaceEdit implements vscode.WorkspaceEdit {
                     ~~~~~~~~~~~~~


npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! python@2018.8.0-alpha vscode:prepublish: `gulp checkNativeDependencies && tsc -p ./`
npm ERR! Exit status 2

I guess 1.26 added createFile

@MikhailArkhipov MikhailArkhipov merged commit 6369262 into microsoft:master Aug 21, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add control setting for LS logging level Drop Typeshed from the repo

2 participants

@MikhailArkhipov @brettcannon