Update language server modules to latest release - #23623
Merged
Rich Chiodo (rchiodo) merged 4 commits intoJun 17, 2024
Merged
Conversation
Rich Chiodo (rchiodo)
requested review from
Courtney Webster (cwebster-99),
Erik De Bonte (debonte) and
Karthik Nadig (karthiknadig)
June 14, 2024 20:23
| import { IDisposableRegistry, IExtensions } from '../common/types'; | ||
| import { IServiceContainer } from '../ioc/types'; | ||
| import { sendTelemetryEvent } from '../telemetry'; | ||
| import { createHidingMiddleware } from './hidingMiddleware'; |
There was a problem hiding this comment.
Turns out this update wasn't quite so automatic. The _Window middleware changed its signature. This meant the middleware exported from the jupyter-lsp-middleware npm module would also need to be updated. Given we haven't updated that in 2 years (and I didn't want to go through the hoops to get it published again), I just copied that code here. It was the only thing used from that module.
| }; | ||
|
|
||
| const client = new LanguageClient('python', 'Python Language Server', clientOptions, worker); | ||
| const client = new LanguageClient('python', 'Python Language Server', worker, clientOptions); |
There was a problem hiding this comment.
The order of the arguments changed on this constructor.
Erik De Bonte (debonte)
previously approved these changes
Jun 15, 2024
Co-authored-by: Erik De Bonte <erikd@microsoft.com>
Author
|
Erik De Bonte (@debonte) for some reason accepting your suggestions requires another review sign off |
Erik De Bonte (debonte)
approved these changes
Jun 17, 2024
Rich Chiodo (rchiodo)
enabled auto-merge (squash)
June 17, 2024 16:38
Don Jayamanne (DonJayamanne)
pushed a commit
that referenced
this pull request
Jun 24, 2024
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402 --------- Co-authored-by: Erik De Bonte <erikd@microsoft.com>
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jun 28, 2024
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402 --------- Co-authored-by: Erik De Bonte <erikd@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402