Ensure default browser is launched on Windows for survey/information popups. [ALTERNATE]#2359
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2359 +/- ##
=========================================
+ Coverage 75.98% 76% +0.01%
=========================================
Files 309 309
Lines 14341 14331 -10
Branches 2540 2537 -3
=========================================
- Hits 10897 10892 -5
+ Misses 3434 3429 -5
Partials 10 10
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Aug 9, 2018
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2252 (using a URL with a query string launches windows file explorer, not the default browser).
Make use of
opnwithin theBrowserService, fixing all potential uses across the extension.Please see my other PR Ensure default browser is launched on Windows for survey/information popups. #2358 for an alternate fix.
Title summarizes what is changing
Includes a news entry file (remember to thank yourself!)
Unit tests & code coverage are not adversely affected (within reason)
Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
Note: No tests for this PR, as the issue is with how the OS interprets the string we are sending. I am not positive how I can test that one!