Skip to content

Add setting to control speed of diagnostic publishing#2357

Merged
MikhailArkhipov merged 39 commits into
microsoft:masterfrom
MikhailArkhipov:master
Aug 9, 2018
Merged

Add setting to control speed of diagnostic publishing#2357
MikhailArkhipov merged 39 commits into
microsoft:masterfrom
MikhailArkhipov:master

Conversation

@MikhailArkhipov
Copy link
Copy Markdown

@MikhailArkhipov MikhailArkhipov commented Aug 9, 2018 •
edited
Loading

Fixes #2270

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

microsoft/PTVS#4612

MikhailArkhipov and others added 30 commits June 8, 2018 14:07
LS symbol providers
997635a
Merge branch 'master' of https://github.com/Microsoft/vscode-python
f6c6276
Merge branch 'master' of https://github.com/Microsoft/vscode-python
0a20fef
Merge branch 'master' of https://github.com/Microsoft/vscode-python
660a627
Merge branch 'master' of https://github.com/Microsoft/vscode-python
3813395
Different ready wait
d4fd3ab
Merge branch 'master' of https://github.com/Microsoft/vscode-python
3a0bea4
Upgrade dependencies to latest LS
56bf688
Make open files only default
37f1154
Turn off hash checks
4092bcc
Fix double progress display
49ec38a
Update packages
f7e245b
@brettcannon
Anchor dependencies
bdce0ff
Merge branch 'master' of https://github.com/Microsoft/vscode-python
969db02
Merge master
13828ca
Add setting for diag throttling
5d45558
Add MacOS version check
70b13f7
News
462ff7c
Correct MacOS check and lay infra for Linux checks
4e12b3c
Linux version check
0d3c066
Linux check
925f663
Simplify
fef0e92
Test prep
2c7243c
Platform tests
07dc2fa
Mac compat tests
cd970be
Ubuntu tests
c63c904
Revert "Ubuntu tests"
42ebdd1 
This reverts commit c63c904.
Revert "Mac compat tests"
d3c7acb 
This reverts commit cd970be.
Revert "Platform tests"
d86997b 
This reverts commit 07dc2fa.
Revert "Test prep"
5caca65 
This reverts commit 2c7243c.
MikhailArkhipov added 9 commits August 8, 2018 17:22
d3r3kk
d3r3kk suggested changes Aug 9, 2018
View reviewed changes
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just fine 👍, but let's add a few tests before we submit...

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2018 •
edited
Loading

Codecov Report

Merging #2357 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
+ Coverage   75.98%   76.13%   +0.14%     
==========================================
  Files         309      309              
  Lines       14341    14341              
  Branches     2540     2540              
==========================================
+ Hits        10897    10918      +21     
+ Misses       3434     3413      -21     
  Partials       10       10
Flag Coverage Δ
#MacOS 74.17% <100%> (ø) ⬆️
#Windows 74.33% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
src/client/activation/languageServer.ts 26.08% <100%> (ø) ⬆️
src/client/linters/lintingEngine.ts 91.15% <0%> (-0.89%) ⬇️
src/client/linters/baseLinter.ts 95.78% <0%> (+6.31%) ⬆️
src/client/common/application/applicationShell.ts 30.76% <0%> (+7.69%) ⬆️
src/client/common/logger.ts 68.42% <0%> (+10.52%) ⬆️
src/client/linters/errorHandlers/errorHandler.ts 100% <0%> (+22.22%) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 100% <0%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a04cd...d7cd632. Read the comment docs.

@MikhailArkhipov
Copy link
Copy Markdown
Author

MikhailArkhipov commented Aug 9, 2018

Tests for the delay? We'll add those to LS repo when Alex is done porting tests.

@MikhailArkhipov
Copy link
Copy Markdown
Author

MikhailArkhipov commented Aug 9, 2018

microsoft/PTVS#4612

@d3r3kk
Copy link
Copy Markdown

d3r3kk commented Aug 9, 2018

Tests for the delay? We'll add those to LS repo when Alex is done porting tests.

I'm not worried about the delay, this is only a config change. Please pardon my unfamiliarity with how the LS gets it's config settings, I had assumed that VSCode-Python sets them into the LS at some point in the code.

My request for tests would simply to be 'Check that the value set in the config is being sent to the LS', but perhaps that is read directly from our package by the LS itself?

@MikhailArkhipov
Copy link
Copy Markdown
Author

MikhailArkhipov commented Aug 9, 2018

Yep, LS reads it directly. https://github.com/Microsoft/PTVS/blob/master/Python/Product/VSCode/AnalysisVsc/LanguageServer.cs#L155

@d3r3kk
Copy link
Copy Markdown

d3r3kk commented Aug 9, 2018

Good to know, thanks!

@MikhailArkhipov MikhailArkhipov merged commit 9c078c0 into microsoft:master Aug 9, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@d3r3kk d3r3kk d3r3kk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide the ability to turn off live error reporting in the new language server

3 participants

@MikhailArkhipov @d3r3kk @brettcannon