Skip to content

Launch flask in a debug environment with the Flask debug mode disabled#2327

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue2309FlaskDbgConfig
Aug 5, 2018
Merged

Launch flask in a debug environment with the Flask debug mode disabled#2327
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue2309FlaskDbgConfig

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #2309

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • [n/a] Unit tests & code coverage are not adversely affected (within reason)
  • [n/a] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • [n/a] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [n/a] package-lock.json has been regenerated if dependencies have changed

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2018

Codecov Report

Merging #2327 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
+ Coverage   75.69%   75.84%   +0.15%     
==========================================
  Files         309      309              
  Lines       14341    14341              
  Branches     2540     2540              
==========================================
+ Hits        10855    10877      +22     
+ Misses       3476     3454      -22     
  Partials       10       10
Flag Coverage Δ
#MacOS 73.9% <ø> (-0.05%) ⬇️
#Windows 74.15% <ø> (+0.19%) ⬆️
Impacted Files Coverage Δ
src/client/linters/baseLinter.ts 95.78% <0%> (+6.31%) ⬆️
src/client/common/application/applicationShell.ts 30.76% <0%> (+7.69%) ⬆️
src/client/common/logger.ts 68.42% <0%> (+10.52%) ⬆️
src/client/linters/errorHandlers/errorHandler.ts 100% <0%> (+22.22%) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 100% <0%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bca28...3e34186. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 065b377 into microsoft:master Aug 5, 2018
@DonJayamanne DonJayamanne deleted the issue2309FlaskDbgConfig branch October 2, 2018 22:46
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update flask debug configuration to ensure flask is run in debug mode

2 participants