Skip to content

Add debug configuration snippet for modules in Experimental debugger#2216

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue2175Module
Sep 7, 2018
Merged

Add debug configuration snippet for modules in Experimental debugger#2216
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue2175Module

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jul 21, 2018

Fixes #2175

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • [n/a] Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [n/a] package-lock.json has been regenerated if dependencies have changed

@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Aug 1, 2018

Merge conflicts now that the default debugger has changed.

d3r3kk
d3r3kk approved these changes Aug 3, 2018
View reviewed changes
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to consider:

Instead of leaving the value for "module": "module.name" perhaps we can be even more clear if we enter: "enter-your-module-name-here" to make it extra vivid that users must edit this.

When I first used the module mode, I thought that 'module.name' was something that the environment would automatically figure out for me (embracing my ignorance here!).

If it had been named something a bit more explicitly obvious I would have self-corrected, which is the desired behaviour here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2018 •
edited
Loading

Codecov Report

Merging #2216 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
+ Coverage   75.69%   75.69%   +<.01%     
==========================================
  Files         309      309              
  Lines       14341    14341              
  Branches     2540     2540              
==========================================
+ Hits        10855    10856       +1     
+ Misses       3476     3475       -1     
  Partials       10       10
Flag Coverage Δ
#MacOS 73.87% <ø> (-0.07%) ⬇️
#Windows 74.01% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
src/client/linters/lintingEngine.ts 92.03% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bca28...6429767. Read the comment docs.

@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Aug 20, 2018

@DonJayamanne anything holding up merging this?

@DonJayamanne DonJayamanne merged commit a3c8d04 into microsoft:master Sep 7, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@d3r3kk d3r3kk d3r3kk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create module launch configuration snippet for experimental debugger

3 participants

@DonJayamanne @brettcannon @d3r3kk