Skip to content

Pass OS type to the debugger#2129

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue2128
Jul 11, 2018
Merged

Pass OS type to the debugger#2129
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue2128

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jul 10, 2018

Fixes #2128

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

d3r3kk
d3r3kk approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the build failures are handled this looks just fine. Do we want to put in 'MacClient' as well?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2018 •
edited
Loading

Codecov Report

Merging #2129 into master will decrease coverage by 0.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
- Coverage      80%   79.49%   -0.52%     
==========================================
  Files         307      308       +1     
  Lines       14118    14330     +212     
  Branches     2511     2568      +57     
==========================================
+ Hits        11295    11391      +96     
- Misses       2811     2927     +116     
  Partials       12       12
Flag Coverage Δ
#MacOS 74% <100%> (-0.2%) ⬇️
#Windows 74.07% <100%> (-0.22%) ⬇️
Impacted Files Coverage Δ
src/client/debugger/Common/Contracts.ts 100% <100%> (ø) ⬆️
...lient/debugger/configProviders/pythonV2Provider.ts 87.5% <100%> (+0.15%) ⬆️
src/client/debugger/mainV2.ts 74.05% <0%> (-11.89%) ⬇️
src/client/common/types.ts 100% <0%> (ø) ⬆️
src/client/activation/progress.ts 28.57% <0%> (ø)
...rc/client/debugger/PythonProcessCallbackHandler.ts 68.75% <0%> (+0.32%) ⬆️
src/client/activation/analysis.ts 28.57% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db68b03...1ae06af. Read the comment docs.

@DonJayamanne
Copy link
Copy Markdown
Author

DonJayamanne commented Jul 10, 2018

Mac and Linux is a subset of UnixClient

@DonJayamanne DonJayamanne merged commit 5afeba8 into microsoft:master Jul 11, 2018
@DonJayamanne DonJayamanne deleted the issue2128 branch October 2, 2018 22:47
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@d3r3kk d3r3kk d3r3kk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass new debugOption to debugger for Unix Clients

2 participants

@DonJayamanne @d3r3kk