Skip to content

Coverage reporting in codecove & in VSTS (1st pass)#2059

Merged
d3r3kk merged 5 commits into
microsoft:masterfrom
d3r3kk:cov
Jun 25, 2018
Merged

Coverage reporting in codecove & in VSTS (1st pass)#2059
d3r3kk merged 5 commits into
microsoft:masterfrom
d3r3kk:cov

Conversation

@d3r3kk
Copy link
Copy Markdown

@d3r3kk d3r3kk commented Jun 25, 2018

This PR will enable code coverage in VSTS going forward, but doesn't complete the effort.

  • Enables VSTS console logging for all tests (and allows us to set a different mocha report via env var)
  • Enables Cobertura format coverage reporting in addition to the original report formats.
  • Corrects logic in the cover:disable function.
  • Embeds CSS in the HTML coverage report generated (needed for VSTS), but only when cover:inlinesources gulp function is called.

Some further info here: #2058

d3r3kk and others added 5 commits June 22, 2018 15:01
- constant can be altered by setting an env var
- MOCHA_CI_REPORTER_ID can be set to a reporter
- default value is mocha-junit-reporter
- Now we can move the VSTS reporter wherever we wish, or use some other reporter
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2018

Codecov Report

Merging #2059 into master will increase coverage by 4.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   75.04%   79.92%   +4.88%     
==========================================
  Files         307      307              
  Lines       14060    14060              
  Branches     2493     2493              
==========================================
+ Hits        10551    11238     +687     
+ Misses       3373     2810     -563     
+ Partials      136       12     -124
Flag Coverage Δ
#Windows 74.18% <ø> (?)
Impacted Files Coverage Δ
src/client/unittests/display/main.ts 88.28% <0%> (+0.78%) ⬆️
src/client/linters/lintingEngine.ts 92.03% <0%> (+0.88%) ⬆️
src/client/linters/baseLinter.ts 91.57% <0%> (+1.05%) ⬆️
src/client/providers/itemInfoSource.ts 88.17% <0%> (+1.07%) ⬆️
src/client/providers/simpleRefactorProvider.ts 81.72% <0%> (+1.07%) ⬆️
src/client/debugger/banner.ts 80% <0%> (+1.17%) ⬆️
src/client/language/characterStream.ts 97.05% <0%> (+1.47%) ⬆️
src/client/language/characters.ts 67.64% <0%> (+1.47%) ⬆️
src/client/unittests/common/runner.ts 92.64% <0%> (+1.47%) ⬆️
...t/interpreter/locators/services/condaEnvService.ts 87.87% <0%> (+1.51%) ⬆️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8885912...95e83ef. Read the comment docs.

@d3r3kk d3r3kk closed this Jun 25, 2018
@d3r3kk
Copy link
Copy Markdown
Author

d3r3kk commented Jun 25, 2018

MacOS agents stalled, and we were missing the MOCHA_CI_REPORTER_ID env var in this build! Restarted to try mac over again, and to get the sweet sweet reporting action afforded by our extension to the mocha-junit-reporter.

@d3r3kk d3r3kk reopened this Jun 25, 2018
@d3r3kk d3r3kk closed this Jun 25, 2018
@d3r3kk
Copy link
Copy Markdown
Author

d3r3kk commented Jun 25, 2018

One last attempt to get MacOS agents to respond...

@d3r3kk d3r3kk reopened this Jun 25, 2018
@d3r3kk d3r3kk merged commit b769f55 into microsoft:master Jun 25, 2018
@d3r3kk d3r3kk deleted the cov branch June 25, 2018 20:52
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants