Predictable ids for Conda envs without Python#20496
Conversation
| fileName = | ||
| getOSType() === OSType.Windows ? path.join(env.envPath, fileName) : path.join(env.envPath, 'bin', fileName); | ||
| } | ||
| resolvedEnv.id = getEnvID(fileName, resolvedEnv.location); |
There was a problem hiding this comment.
I think this is a valid approach, because the new env will take the place of this old env.
& worst case scenario, the id will be different from the old env, which is already the case, hence no harm
karrtikr
left a comment
There was a problem hiding this comment.
I like the idea. But there're multiple places where we'll have to handle this change, making sure environment with old IDs are removed from cache, checking instances of getEnvID elsewhere etc.
It's probably better to holistically tackle it later if this change is not required atm, if it is though, let me know and I can reopen the PR.
This change is required, and makes it almost impossible to use conda envirronments without python. |
|
Closing in favor of #20609. |
Fixes #20176