Add typeshed submodule and pass it down to LS#2043
Merged
Conversation
DonJayamanne
approved these changes
Jun 25, 2018
d3r3kk
reviewed
Jun 25, 2018
| const extraPaths = settings.autoComplete.extraPaths; | ||
| if (extraPaths && extraPaths.length > 0) { | ||
| searchPaths = `${searchPaths};${extraPaths.join(';')}`; | ||
| searchPathsString = `${searchPathsString};${extraPaths.join(';')}`; |
There was a problem hiding this comment.
What happens when searchPathsString=''? Is it ok for it to contain a leading ';' when it does equal the empty string?
Author
There was a problem hiding this comment.
For the LS yes. It always uses ; as separator and drops odd entries.
This was referenced Jun 27, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
Will add tests when microsoft/PTVS#4412 completes