Skip to content

Add Pytest Code But Keep Inactive for Pytest Discovery#20210

Closed
eleanorjboyd wants to merge 35 commits into
microsoft:mainfrom
eleanorjboyd:pytest_discovery_inactive_addition
Closed

Add Pytest Code But Keep Inactive for Pytest Discovery#20210
eleanorjboyd wants to merge 35 commits into
microsoft:mainfrom
eleanorjboyd:pytest_discovery_inactive_addition

Conversation

@eleanorjboyd
Copy link
Copy Markdown
Member

@eleanorjboyd eleanorjboyd commented Nov 10, 2022

Fixes #20079

@eleanorjboyd eleanorjboyd self-assigned this Nov 10, 2022
@eleanorjboyd eleanorjboyd added the no-changelog No news entry required label Nov 10, 2022
Comment thread src/client/testing/testController/controller.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
@eleanorjboyd eleanorjboyd marked this pull request as ready for review November 11, 2022 19:42
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 11, 2022
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestExecutionAdapter.ts Outdated
Comment thread src/client/testing/testController/controller.ts Outdated
karrtikr
karrtikr previously approved these changes Jan 31, 2023
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
Comment thread src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts Outdated
@eleanorjboyd eleanorjboyd requested a review from karrtikr January 31, 2023 17:45
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other console.* calls as well.

@eleanorjboyd
Copy link
Copy Markdown
Member Author

closing in favor of #20566

@eleanorjboyd eleanorjboyd deleted the pytest_discovery_inactive_addition branch January 31, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect Pytest Discovery Plugin to Testing UI

5 participants