Skip to content

Pytest plugin cherrypick#20175

Closed
eleanorjboyd wants to merge 54 commits into
microsoft:mainfrom
eleanorjboyd:pytest_plugin_cherrypick
Closed

Pytest plugin cherrypick#20175
eleanorjboyd wants to merge 54 commits into
microsoft:mainfrom
eleanorjboyd:pytest_plugin_cherrypick

Conversation

@eleanorjboyd
Copy link
Copy Markdown
Member

@eleanorjboyd eleanorjboyd commented Nov 7, 2022

Fixes #20077

Eleanor Boyd and others added 30 commits November 7, 2022 13:36
…19828)

For microsoft#19101

Before the change item events start coming in, we have to ensure
quickpick is ready to receive those events.
…nent (microsoft#19827)

Ensure we start watchers and create workspace related objects when
activating discovery component
Done temporarily on request of Pylance so they can begin testing.
@eleanorjboyd eleanorjboyd marked this pull request as ready for review November 7, 2022 22:37
@eleanorjboyd eleanorjboyd self-assigned this Nov 7, 2022
@eleanorjboyd eleanorjboyd added the no-changelog No news entry required label Nov 7, 2022
Comment thread pythonFiles/pytest-vscode-integration/MANIFEST.in Outdated
Comment thread pythonFiles/pytest-vscode-integration/appveyor.yml Outdated
Comment thread pythonFiles/pytest-vscode-integration/setup.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tox.ini Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Comment thread pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated
Copy link
Copy Markdown
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no .egg-info directory in the repo (or anywhere). That's really old setuptools stuff. If we have to have an entry_points.txt file then it should be in a .dist-info directory for the code. In fact there should be no use of setuptools in our repo as it's too heavy-handed for what we need it for. We should be using flit_core or hatchling as a build back-end instead since we only have pure Python packages. I.e. no setup.py, only pyproject.toml.

Have you tried using the -p option with the directory containing the plug-in on PYTHONPATH (or some other way to get it on to sys.path)? The wording of https://docs.pytest.org/en/stable/how-to/writing_plugins.html#making-your-plugin-installable-by-others suggests it might not be necessary to define an entry point. It also has an example of how to use pyproject.toml and hatchling to package things up if it turns out we actually do have to provide an entry point.

@eleanorjboyd
Copy link
Copy Markdown
Member Author

closing in favor of #20566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and Commit Pytest Plugin (without enabling)

5 participants