19767 remove di in resolvers#20048
Merged
paulacamargo25 merged 9 commits intoOct 25, 2022
Merged
Conversation
df68fb6 to
6dfdf6a
Compare
karthiknadig
requested changes
Oct 24, 2022
| @@ -0,0 +1,19 @@ | |||
| export enum OSType { | |||
Member
There was a problem hiding this comment.
This is already defined in src\client\common\utils\platform.ts
Author
There was a problem hiding this comment.
Yes, but I am trying to separate the utils from the debugger so that when we move it to the other extension we only have the functions that we use.
Member
There was a problem hiding this comment.
You may have to pull a lot of things from commons anyway. Separating it like this now might not help.
Author
There was a problem hiding this comment.
oh okay, im going to use the one in common.
karthiknadig
approved these changes
Oct 24, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #19767