Skip to content

Update message displayed in the Experimental Debugger banner#1996

Merged
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:issue1968FurtherChanges
Jun 18, 2018
Merged

Update message displayed in the Experimental Debugger banner#1996
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:issue1968FurtherChanges

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1968

This pull request:

  • Has a title summarizes what is changing

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2018

Codecov Report

Merging #1996 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
+ Coverage   74.86%   74.89%   +0.03%     
==========================================
  Files         302      302              
  Lines       13693    13692       -1     
  Branches     2429     2429              
==========================================
+ Hits        10251    10255       +4     
+ Misses       3310     3302       -8     
- Partials      132      135       +3
Impacted Files Coverage Δ
.../application/diagnostics/checks/envPathVariable.ts 97.61% <ø> (ø) ⬆️
src/client/debugger/banner.ts 78.82% <100%> (+10.21%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/Main.ts 51.85% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db4ff5...4741e4a. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the issue1968FurtherChanges branch from b0fa3d2 to 4741e4a Compare June 18, 2018 19:53
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@d3r3kk d3r3kk closed this Jun 18, 2018
@d3r3kk d3r3kk reopened this Jun 18, 2018
@d3r3kk
Copy link
Copy Markdown

d3r3kk commented Jun 18, 2018

VSTS decided to cancel the build.

@DonJayamanne DonJayamanne merged commit f1e43a6 into microsoft:master Jun 18, 2018
@DonJayamanne DonJayamanne deleted the issue1968FurtherChanges branch June 20, 2018 03:13
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback banner for experimental debugger

2 participants