Skip to content

Display banner prompting user to fill a survey for Experimental Debugger#1976

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1968DbgBanner
Jun 15, 2018
Merged

Display banner prompting user to fill a survey for Experimental Debugger#1976
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1968DbgBanner

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Jun 14, 2018

Fixes #1968

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

d3r3kk
d3r3kk approved these changes Jun 15, 2018
View reviewed changes
Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit d8044f9 into microsoft:master Jun 15, 2018
@DonJayamanne DonJayamanne deleted the issue1968DbgBanner branch June 20, 2018 03:13
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@d3r3kk d3r3kk d3r3kk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feedback banner for experimental debugger

2 participants

@DonJayamanne @d3r3kk