Skip to content

Do not assume the Linux distro to be debian if dnf is not found while installing python#19582

Merged
karrtikr merged 2 commits into
microsoft:mainfrom
karrtikr:asjasas
Jul 27, 2022
Merged

Do not assume the Linux distro to be debian if dnf is not found while installing python#19582
karrtikr merged 2 commits into
microsoft:mainfrom
karrtikr:asjasas

Conversation

@karrtikr

@karrtikr karrtikr commented Jul 27, 2022

Copy link
Copy Markdown

Closes #19448

image

@karrtikr karrtikr changed the title Do not assume the Linux disto to be debian if dnf is not found while installing python Do not assume the Linux distro to be debian if dnf is not found while installing python Jul 27, 2022
@karrtikr karrtikr added the no-changelog No news entry required label Jul 27, 2022
@karrtikr karrtikr force-pushed the asjasas branch 4 times, most recently from fd48475 to 0df0fc4 Compare July 27, 2022 23:00
@karrtikr karrtikr marked this pull request as ready for review July 27, 2022 23:30
@karrtikr karrtikr requested a review from rzhao271 July 27, 2022 23:31
Comment thread src/client/common/utils/localize.ts Outdated
@rzhao271

Copy link
Copy Markdown

Other than that, LGTM

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@karrtikr karrtikr merged commit fa0e60a into microsoft:main Jul 27, 2022
@karrtikr karrtikr deleted the asjasas branch July 27, 2022 23:43
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
… installing python (microsoft/vscode-python#19582)

* Implement

* Code reviews

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have the "Install Python" command from the walkthrough open and fill in the suggested command

2 participants