Skip to content

New Unittest Execution#19386

Merged
anthonykim1 merged 49 commits into
microsoft:mainfrom
anthonykim1:unittest_execution
Aug 1, 2022
Merged

New Unittest Execution#19386
anthonykim1 merged 49 commits into
microsoft:mainfrom
anthonykim1:unittest_execution

Conversation

@anthonykim1

@anthonykim1 anthonykim1 commented Jun 29, 2022

Copy link
Copy Markdown

Unititest execution is now possible through the new way from gathering test result data from execution.py to and throughout testExecutionAdapter.ts <=> workspaceTestAdapter.ts <=> controller.ts. VS Code UI are updated appropriately after clicking on the "run" button for each of the demanded test element.

  • Invalid Argument error was fixed after finding out line number type of string was being based in for message.range instead of type of number/integer.
  • message should now be shown in the correct location without crashing the UI with appropriate result, traceback if necessary.

@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Jun 29, 2022
@anthonykim1 anthonykim1 self-assigned this Jun 29, 2022
@anthonykim1 anthonykim1 marked this pull request as ready for review July 18, 2022 08:23
@anthonykim1 anthonykim1 requested a review from karthiknadig July 18, 2022 08:23
Comment thread pythonFiles/unittestadapter/execution.py Outdated
Comment thread pythonFiles/unittestadapter/execution.py Outdated
Comment thread pythonFiles/unittestadapter/execution.py Outdated
Comment thread pythonFiles/unittestadapter/execution.py Outdated
Comment thread src/client/testing/testController/common/server.ts Outdated
Comment thread pythonFiles/unittestadapter/discovery.py Outdated
Comment thread pythonFiles/unittestadapter/discovery.py Outdated
Comment thread pythonFiles/unittestadapter/execution.py Outdated
Comment thread src/client/testing/testController/common/server.ts Outdated
Comment thread src/test/testing/testController/server.unit.test.ts Outdated
@anthonykim1 anthonykim1 changed the title Adding execution fixes. New Unittest Execution Aug 1, 2022
karthiknadig
karthiknadig previously approved these changes Aug 1, 2022
@anthonykim1 anthonykim1 merged commit 4b4449e into microsoft:main Aug 1, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Adding execution fixes.

* add map of runIDToTestItem for workspaceTestAdapter instance

* update UI accordingly using new execution method

* attempt to fix invalid argument

* fix invalid argument

* add traceback to the message

* attempt to fix runID

* remove import Codetypes

* change runtest pattern to non optional

* remove unnecessary import comments

* add code for unittest execution debugger

* add noop,traceError to solve mergeConflict

* fix malfunctioning execution, skipped and expected failure outcome

* allow cherry pick test runs for efficiency

* add subtest update and directory search

* leave new debugLauncher dormant and try to fix python type

* ignore type for runner.run as in the past

* cleanup execution.py

* typescript side cleanup

* move the runInstance starting up before executing

* remove unnecessary debugLauncher check

* get rid of TypeAlias

* move uuid to header instead of inside payload

* fix python test and look server unittest

* test out timeout

* try adding requestuuid to avoid timeout

* try using rawHeaders.push

* try inserting uuid inside option command

* fix all server.unit.test.ts problem caused by moving uuid to header

* get rid of unused variable warning

* windows python test server

* pass in debuglauncher to new python test server in all of server.unit.test.ts instances

* make debugLauncher non optional on server.ts

* fix unnecessary comments on discovery

* rename requestuuid to request-uuid

* rename parse_unittest_discovery_args and move to utils

* attempt to fix the moduleNotFound for utils

* attempt to fix moduleNotFound2

* rearrange os.path

* undo rearrange os.path

* test that were not found mark as skipped

* fix set subtraction

* remove unnecessary not found which is handled earlier by tailor run and result

* fix broken discovery refresh

* fix warnings regarding unused

* remove unused variable

* fix testData doesnt exist error

* remove unused methods

* comment new unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants