Skip to content

Trim the contents of pipenv dot project file after reading it #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 2 commits into from
Mar 22, 2022
Merged

Trim the contents of pipenv dot project file after reading it #18747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5709d14
Trim the contents of pipenv dot project file after reading it
Mar 22, 2022
520cb3b
Update tests
Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/pythonEnvironments/common/environmentManagers/pipenv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async function getProjectDir(envFolder: string): Promise<string | undefined> {
if (!(await pathExists(dotProjectFile))) {
return undefined;
}
const projectDir = await readFile(dotProjectFile);
const projectDir = (await readFile(dotProjectFile)).trim();
if (!(await pathExists(projectDir))) {
traceError(
`The .project file inside environment folder: ${envFolder} doesn't contain a valid path to the project`,
Expand Down
2 changes: 1 addition & 1 deletion ...pythonEnvironments/common/envlayouts/pipenv/globalEnvironments/project2-vnNIWe9P/.project
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Absolute path to \src\test\pythonEnvironments\common\envlayouts\pipenv\project2
Absolute path to \src\test\pythonEnvironments\common\envlayouts\pipenv\project2
2 changes: 1 addition & 1 deletion ...onments/common/envlayouts/virtualhome/.local/share/virtualenvs/project2-vnNIWe9P/.project
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Absolute path to \src\test\pythonEnvironments\common\envlayouts\pipenv\project2
Absolute path to \src\test\pythonEnvironments\common\envlayouts\pipenv\project2