Skip to content

Log Conda not existing message as an information instead of an error#1820

Merged
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1817Logger
Jun 5, 2018
Merged

Log Conda not existing message as an information instead of an error#1820
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1817Logger

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented May 31, 2018 •
edited
Loading

Fixes #1817
Fixes #1821

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@51224e7). Click here to learn what that means.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1820   +/-   ##
=========================================
  Coverage          ?   74.11%           
=========================================
  Files             ?      282           
  Lines             ?    13132           
  Branches          ?     2349           
=========================================
  Hits              ?     9733           
  Misses            ?     3266           
  Partials          ?      133
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø)
src/client/common/logger.ts 42.1% <0%> (ø)
...ient/interpreter/locators/services/condaService.ts 97.39% <100%> (ø)
...gger/configProviders/configurationProviderUtils.ts 100% <100%> (ø)
...ent/interpreter/locators/services/pipEnvService.ts 84.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51224e7...72549cd. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 4325ac1 into microsoft:master Jun 5, 2018
@DonJayamanne DonJayamanne deleted the issue1817Logger branch June 20, 2018 03:13
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ILogger instead of console.error to reduce noise in unit tests Don't log conda not existing as a failure

2 participants

@DonJayamanne @brettcannon