Use dotenv package to parse environment variables definition files#1802
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1802 +/- ##
==========================================
- Coverage 74.1% 74.06% -0.05%
==========================================
Files 282 282
Lines 13089 13074 -15
Branches 2335 2330 -5
==========================================
- Hits 9700 9683 -17
- Misses 3259 3260 +1
- Partials 130 131 +1
Continue to review full report at Codecov.
|
d3r3kk
approved these changes
May 31, 2018
| resolve(parseEnvironmentVariables(data)); | ||
| }); | ||
| }); | ||
| return dotenv.parse(filePath); |
There was a problem hiding this comment.
Cool! This package - does it deal with multiple encoding then?
Author
There was a problem hiding this comment.
yes and no. We basically need tell it the encoding that needs to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1376
This pull request: