So Travis says it's passing, but if you look at the details every single test failed. https://travis-ci.org/Microsoft/vscode-python/jobs/385379858#L677 suggests there might be a problem. Do you happen to know what's going on, @DonJayamanne ?

Codecov Report

Merging #1771 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
- Coverage   74.44%   74.05%   -0.39%     
==========================================
  Files         282      282              
  Lines       13253    13089     -164     
  Branches     2382     2335      -47     
==========================================
- Hits         9866     9693     -173     
- Misses       3257     3264       +7     
- Partials      130      132       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f48a19...6fc060c. Read the comment docs.

@brettcannon
Found the problem, temporary solution is to change "@types/node": "^9.4.7", to "@types/node": "9.4.7",

We'll need to update the dev and standard dependencies together next time.

Here's a detailed explanation of the problem:

• Iconv-lite relies on node.js (< 9.6)
• Node.js typings are in dev dependencies (>= 9.4.7)
• Package.lock is pulling down node.js 9.6.*
• The new dev version of node.js typings doesn't match with iconv-lite

If Travis succeeds then this PR is safe to go in, I'll update the CI on VSTS to switch over to npm now.

NOTE: I killed the VSTS build, please ignore it for the purpose of this PR.

Edit: Claim responsibility for CI build cancellation.