Skip to content

Prompt to reload VS Code when changing analysis engines#1754

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1747Activation
May 28, 2018
Merged

Prompt to reload VS Code when changing analysis engines#1754
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1747Activation

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1747

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2018

Codecov Report

Merging #1754 into master will increase coverage by 0.18%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   73.72%   73.91%   +0.18%     
==========================================
  Files         279      282       +3     
  Lines       13049    13117      +68     
  Branches     2329     2338       +9     
==========================================
+ Hits         9620     9695      +75     
+ Misses       3292     3291       -1     
+ Partials      137      131       -6
Impacted Files Coverage Δ
src/client/linters/lintingEngine.ts 90.26% <ø> (-0.97%) ⬇️
src/client/formatters/baseFormatter.ts 75% <ø> (-0.35%) ⬇️
src/client/ioc/serviceManager.ts 90.47% <100%> (+0.47%) ⬆️
src/client/activation/types.ts 100% <100%> (ø)
src/client/activation/serviceRegistry.ts 100% <100%> (ø)
src/client/common/constants.ts 100% <100%> (ø) ⬆️
src/client/extension.ts 96.96% <100%> (+0.78%) ⬆️
src/client/common/types.ts 100% <100%> (ø) ⬆️
src/client/activation/analysis.ts 16.54% <25%> (+1.27%) ⬆️
src/client/activation/classic.ts 91.83% <80%> (-3.29%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0420bd4...f9716ad. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 997f99b into microsoft:master May 28, 2018
@DonJayamanne DonJayamanne deleted the issue1747Activation branch June 20, 2018 03:13
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prompt to restart VS Code if new language server is enabled/disabled

2 participants