Upload extension to the Azure blob even if tests fail in master branch#1749
Merged
DonJayamanne merged 3 commits intoMay 25, 2018
Merged
Conversation
brettcannon
approved these changes
May 24, 2018
d3r3kk
approved these changes
May 24, 2018
d3r3kk
left a comment
There was a problem hiding this comment.
I imagine this is desired behaviours but I wanted to ask some questions surrounding the automation involved.
| fi | ||
| after_success: | ||
| - if [ $AZURE_STORAGE_ACCOUNT ]; then | ||
| - if [[ $AZURE_STORAGE_ACCOUNT && "$TRAVIS_BRANCH" == "master" && "$TRAVIS_PULL_REQUEST" == "false" ]]; then |
There was a problem hiding this comment.
What if the build fails altogether? As in, what if compilation fails. Would this be possible? What happens then?
Author
There was a problem hiding this comment.
If compilation fails, then extension is not generated, thus upload fails, i.e. all is good
| yarn run clean; | ||
| vsce package; | ||
| azure storage blob upload --container $AZURE_STORAGE_CONTAINER --blob ms-python-insiders.vsix --account-name $AZURE_STORAGE_ACCOUNT --account-key $AZURE_STORAGE_ACCESS_KEY --file python*.vsix --quiet; | ||
| azure storage blob upload python*.vsix $AZURE_STORAGE_CONTAINER ms-python-insiders.vsix --account-name $AZURE_STORAGE_ACCOUNT --account-key $AZURE_STORAGE_ACCESS_KEY --quiet; |
There was a problem hiding this comment.
Is there only one vsix with this name pattern? Or are we trying to upload multiples?
Author
There was a problem hiding this comment.
Only one, but the name changes with each version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1730
This pull request: