Skip to content

Fix jedi requirements#17470

Merged
kimadeline merged 4 commits into
microsoft:mainfrom
kimadeline:17464-fix-jedi-reqs
Sep 20, 2021
Merged

Fix jedi requirements#17470
kimadeline merged 4 commits into
microsoft:mainfrom
kimadeline:17464-fix-jedi-reqs

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Sep 20, 2021

Closes #17464, no error when running Organize Imports:

image

Reverted the change introduced in #17446, and re-added the following:

  • Removed the 3.6 requirement for isort
  • Moved the isort installation step to the Python 3 steps in GitHub workflows (with Jedi LSP)
  • Added a 3.6 comment in jedils_requirements.txt

@kimadeline kimadeline added the no-changelog No news entry required label Sep 20, 2021
@kimadeline kimadeline self-assigned this Sep 20, 2021
@kimadeline kimadeline added the skip tests Updates to tests unnecessary label Sep 20, 2021
@kimadeline kimadeline merged commit e25dd77 into microsoft:main Sep 20, 2021
@kimadeline kimadeline deleted the 17464-fix-jedi-reqs branch September 20, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isort error on "Organize imports"

2 participants