Skip to content

Ensure none of the npm packages rely on native dependencies#1655

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1416NativeDeps
May 11, 2018
Merged

Ensure none of the npm packages rely on native dependencies#1655
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1416NativeDeps

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1416

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2018

Codecov Report

Merging #1655 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1655     +/-   ##
=========================================
- Coverage    71.4%   71.31%   -0.1%     
=========================================
  Files         277      277             
  Lines       12985    12985             
  Branches     2334     2334             
=========================================
- Hits         9272     9260     -12     
- Misses       3578     3585      +7     
- Partials      135      140      +5
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 47.91% <0%> (-3.34%) ⬇️
src/client/debugger/mainV2.ts 75% <0%> (-0.81%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4374fe...f31aaf2. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 3085cb1 into microsoft:master May 11, 2018
@DonJayamanne DonJayamanne deleted the issue1416NativeDeps branch June 20, 2018 03:17
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure none of the npm packages use native dependencies

2 participants