Skip to content

Replace deprecated ExP methods with the newer ones #16486

Merged
kimadeline merged 42 commits into
microsoft:mainfrom
kimadeline:15964-deprecated-exp-methods-update
Jun 23, 2021
Merged

Replace deprecated ExP methods with the newer ones #16486
kimadeline merged 42 commits into
microsoft:mainfrom
kimadeline:15964-deprecated-exp-methods-update

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Jun 15, 2021 •
edited
Loading

@kimadeline kimadeline added the no-changelog No news entry required label Jun 15, 2021
Kim-Adeline Miguel added 27 commits June 15, 2021 13:34
Fix TB tests
7a2952c
Update venv tests
a6739f2
inExperiment -> true
07cf015
inDiscoveryExperiment -> true
7c319b8
Add logging
44f202b
More logging
76b2241
More more logging
e82f556
Even more logging
c4d079e
Change logging
bbce498
USe provider.constructor.name
0092fab
Circular commands
75c7f6a
replace json.interpreter(interpreter) with path
4eaf9ee
Use provider.constructor.name
d401888
add other logging before getActivationCommands
a192fda
Remove both remaining JSON.stringify
eca5f73
inner logging
c64a4bc
More logging in the env discovery components
70ee9e2
Change a few things
bdc1e69
Remove some of the *2
83a5022
Comment out some logs, double timeouts again
e2b2c01
Add and re-add logs
670b4c4
Try using sync methods
e3c4eed
Re-add isCachedFlightEnabled
307aa47
Re-add isCachedFlightEnabled everywhere
edd2130
Forgot the await
17425a8
Clean up logging
a6b54b6
Merge branch 'main' into 15964-deprecated-exp-methods-update
81efcae
@kimadeline kimadeline mentioned this pull request Jun 21, 2021
Closed
@kimadeline kimadeline marked this pull request as ready for review June 21, 2021 23:11
karrtikr
karrtikr approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the tests in this suite do not pass anyway, I think it's best to revert all changes to this file and disable to test suite for now. I'm working on re-enabling them if possible as part of #16533.

Comment thread src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts Outdated
@kimadeline
Copy link
Copy Markdown
Author

kimadeline commented Jun 23, 2021

Reverted all the changes in src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts, now the tests fails on all platforms so I'm going to skip the entire test suite on all platforms (instead of just Windows).

@kimadeline kimadeline merged commit 16497b6 into microsoft:main Jun 23, 2021
@kimadeline kimadeline deleted the 15964-deprecated-exp-methods-update branch June 23, 2021 23:08
karrtikr pushed a commit that referenced this pull request Jul 30, 2021
Revert "Replace deprecated ExP methods with the newer ones (#16486)"
46fe25f 
This reverts commit 16497b6.
This was referenced Jul 30, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kimadeline kimadeline

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @karthiknadig @karrtikr