Ensure selected interpreter doesn't change when the extension is loading when in experiment#16391
Merged
Conversation
karthiknadig
approved these changes
Jun 4, 2021
kimadeline
approved these changes
Jun 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16291 closes https://github.com/microsoft/vscode-python-internalbacklog/issues/263 Could potentially fix #16197 and https://github.com/microsoft/vscode-python-internalbacklog/issues/256.
Due to design issues that are not trivial to address, configuration settings are initialized in the constructor when creating the classes, when experiment service is not activated.
We need to initialize it again once experiments service is activated before we can access the
pythonPathsetting using it, which was the bug.