Allow user to select TensorBoard plugin missing profiler source files using file picker#15993
Merged
joyceerhl merged 7 commits intoApr 21, 2021
Conversation
kimadeline
approved these changes
Apr 21, 2021
karthiknadig
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #15695
Currently if a jump to source request from the TensorBoard profiler plugin in VS Code fails, there's no indication to the user of what the problem is. This PR adds a quickpick to ask the user to manually specify the source files on disk, and resolves the jump to source request against the user's selected file instead.
We're using a quickpick instead of a prompt because prompts are often ignored--hopefully the user will be less likely to ignore this and get confused about the feature not working.
Screenshot:
GIF:
