Skip to content

Flag program in launch.json as an optional property#1578

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1503
May 7, 2018
Merged

Flag program in launch.json as an optional property#1578
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1503

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1503
Also fix a few other linter warnings/errors.

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2018

Codecov Report

Merging #1578 into master will decrease coverage by 0.23%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
- Coverage   71.65%   71.41%   -0.24%     
==========================================
  Files         273      273              
  Lines       12700    12700              
  Branches     2282     2282              
==========================================
- Hits         9100     9070      -30     
- Misses       3465     3495      +30     
  Partials      135      135
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/common/configSettings.ts 88.16% <ø> (ø) ⬆️
src/client/debugger/Common/Contracts.ts 100% <ø> (ø) ⬆️
src/client/debugger/Main.ts 51.85% <0%> (ø) ⬆️
src/client/workspaceSymbols/generator.ts 35.84% <50%> (ø) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5127486...796f894. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 1e09454 into microsoft:master May 7, 2018
@DonJayamanne DonJayamanne deleted the issue1503 branch June 20, 2018 03:14
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Program in launchArguments must be an optional property

2 participants