Skip to content

Fix failing smoke tests #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 1 commit into from
Mar 8, 2021
Merged

Fix failing smoke tests #15574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3 Code Health/15573.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix failing smoke tests on CI.
6 changes: 3 additions & 3 deletions src/test/smoke/datascience.smoke.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as vscode from 'vscode';
import { JUPYTER_EXTENSION_ID } from '../../client/common/constants';
import { openFile, setAutoSaveDelayInWorkspaceRoot, waitForCondition } from '../common';
import { EXTENSION_ROOT_DIR_FOR_TESTS, IS_SMOKE_TEST } from '../constants';
import { noop, sleep } from '../core';
import { sleep } from '../core';
import { closeActiveWindows, initialize, initializeTest } from '../initialize';
import { verifyExtensionIsAvailable } from './common';

Expand Down Expand Up @@ -75,8 +75,8 @@ suite('Smoke Test: Datascience', () => {
if (await fs.pathExists(outputFile)) {
await fs.unlink(outputFile);
}
// Ignore exceptions (as native editor closes the document as soon as its opened);
await openFile(file).catch(noop);

await vscode.commands.executeCommand('jupyter.opennotebook', vscode.Uri.file(file));

// Wait for 15 seconds for notebook to launch.
// Unfortunately there's no way to know for sure it has completely loaded.
Expand Down