Update proposed API for Notebooks - #15568
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoMar 8, 2021
Merged
Conversation
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Kim-Adeline Miguel (kimadeline)
March 5, 2021 20:14
Kartik Raj (karrtikr)
approved these changes
Mar 5, 2021
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
The insiders test suite is disabled rn, do we want to re-enable it with this PR?
Kim-Adeline Miguel (kimadeline)
approved these changes
Mar 5, 2021
Author
Probably separate pr, not sure why it was disabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm assuming these tests only run in Insiders version of VSCode (based on the file extension).