Switch to extension.open for opening the marketplace#15321
Merged
Conversation
rchiodo
approved these changes
Feb 5, 2021
Member
Author
|
This will fail due to a circular dependency: I tested with the Pylance ones, then saw the Jupyter ones after and fixed them, but didn't test locally. |
Member
Author
|
Solved it my making it a parameter, the cycle was that CommandManager and JupyterExtensionDependencyManager depended directly on each other. Arguably, a better fix is to move the install logic to the command manager, as it is the only user, but that's a more significant change. |
karthiknadig
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #14264
Thanks to microsoft/vscode#115344 (comment), we don't need to use
openwith the schema hack. This command does the same thing.