Fix debugging of pyramid applications#1504
Merged
DonJayamanne merged 1 commit intoApr 26, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 71.28% 71.26% -0.03%
==========================================
Files 271 273 +2
Lines 12639 12667 +28
Branches 2273 2273
==========================================
+ Hits 9010 9027 +17
- Misses 3493 3498 +5
- Partials 136 142 +6
Continue to review full report at Codecov.
|
brettcannon
approved these changes
Apr 26, 2018
| const pythonPath = path.join(workspacePath, 'env', 'bin', 'python'); | ||
| const pserveExecutableName = isWindows ? 'pserve.exe' : 'pserve'; | ||
| const pservePath = pythonPathExists ? path.join(path.dirname(pythonPath), pserveExecutableName) : pserveExecutableName; | ||
| const pyramidFilePath = path.join(path.dirname(pythonPath), 'lib', 'site_packages', 'pyramid', '__init__.py'); |
Member
There was a problem hiding this comment.
Why not just look for pyramid? That way you don't need to take the path.dirname() on the next line?
Author
There was a problem hiding this comment.
I need pyramidFilePath with __init__.py as this needs to be returned by the mocked process (stdout)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1467
Fixes #737
This pull request: