Skip to content

Fix for "Python extension loading..." text never disappears#14969

Merged
karrtikr merged 3 commits into
microsoft:mainfrom
karrtikr:loadingtext
Dec 14, 2020
Merged

Fix for "Python extension loading..." text never disappears#14969
karrtikr merged 3 commits into
microsoft:mainfrom
karrtikr:loadingtext

Conversation

@karrtikr
Copy link
Copy Markdown

@karrtikr karrtikr commented Dec 14, 2020 •
edited
Loading

For #14977

Will create another PR to port this into release branch

@karrtikr karrtikr added the no-changelog No news entry required label Dec 14, 2020
@karrtikr karrtikr changed the title Fix event returned for Python extension loading... text Fix for "Python extension loading..." text never disappears Dec 14, 2020
@karrtikr karrtikr marked this pull request as ready for review December 14, 2020 23:02
@github-actions github-actions Bot requested a review from kimadeline December 14, 2020 23:02
@karrtikr karrtikr mentioned this pull request Dec 14, 2020
Closed
kimadeline
kimadeline approved these changes Dec 14, 2020
View reviewed changes
Comment thread src/client/extensionActivation.ts
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 14, 2020

Codecov Report

Merging #14969 (3f55045) into main (7f0b0d4) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##            main   #14969   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        557      557           
  Lines      26197    26199    +2     
  Branches    3715     3715           
======================================
+ Hits       17045    17046    +1     
- Misses      8458     8459    +1     
  Partials     694      694
Impacted Files Coverage Δ
src/client/pythonEnvironments/legacyIOC.ts 37% <0%> (ø)
...ments/discovery/locators/services/pipEnvService.ts 83% <0%> (-1%) ⬇️
src/client/activation/jedi/activator.ts 70% <0%> (ø)
src/client/common/utils/resourceLifecycle.ts 94% <0%> (ø)
src/client/activation/jedi/analysisOptions.ts 71% <0%> (ø)
src/client/activation/common/cancellationUtils.ts 13% <0%> (ø)
...lient/pythonEnvironments/common/windowsRegistry.ts 23% <0%> (ø)
...nts/discovery/locators/services/condaEnvService.ts 80% <0%> (ø)
...s/discovery/locators/services/KnownPathsService.ts 48% <0%> (ø)
.../discovery/locators/services/currentPathService.ts 90% <0%> (ø)
... and 2 more

@karrtikr karrtikr merged commit 73062ee into microsoft:main Dec 14, 2020
@karrtikr karrtikr deleted the loadingtext branch December 14, 2020 23:24
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Dec 14, 2020
Fix for "Python extension loading..." text never disappears (microsof…
9f0d079 
…t#14969)

* Fix event

* Explicitly activate component adapter

* Fix lint error
karrtikr pushed a commit that referenced this pull request Dec 14, 2020
Fix for "Python extension loading..." text never disappears (#14969)
984799a 
* Fix event

* Explicitly activate component adapter

* Fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karrtikr @codecov-io @karthiknadig @kimadeline