Do not show 'No interpreter is selected' when pythonPath in debug configuration is invalid#14892
Merged
Merged
Conversation
int19h
reviewed
Dec 4, 2020
int19h
reviewed
Dec 4, 2020
ca6532b to
df418a2
Compare
int19h
approved these changes
Dec 4, 2020
added 2 commits
December 7, 2020 15:35
8d84474 to
37e562d
Compare
|
@karrtikr, I was planning on waiting for you to drop the "draft" status here, but do you want a review before that? |
Author
Yes it's marked as draft for other reasons as mentioned in the PR description. |
ericsnowcurrently
suggested changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #14814
Python path source was being calculated incorrectly. We decided that calculating source correctly is not worth the hassle, and assume source is always launch.json for new properties if they're not derived from the old ones.
PR is marked as draft so reviewers are assigned correctly, but it's ready for review. @ericsnowcurrently
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).